This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
test: fix test-timers-first-fire.js #7211
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for contributing this pull request! Here are a few pointers to make sure your submission will be considered for inclusion. The following commiters were not found in the CLA:
You can fix all these things without opening another issue. Please see CONTRIBUTING.md for more information |
Making the test tolerant to rounding errors.
|
This fix is no longer valid. See #8960 |
richardlau
pushed a commit
to ibmruntimes/node
that referenced
this pull request
Jun 17, 2016
Notable changes:
* **http**:
- req.read(0) could cause incoming connections to stall and time out
under certain conditions. (Fedor Indutny) [nodejs#7211](nodejs/node#7211)
- When freeing the socket to be reused in keep-alive Agent wait for
both prefinish and end events. Otherwise the next request may be
written before the previous one has finished sending the body, leading
to a parser errors. (Fedor Indutny) [nodejs#7149](nodejs/node#7149)
* **npm**: upgrade npm to 3.9.5 (Kat Marchán) [nodejs#7139](nodejs/node#7139)
nodejs/node#7323
richardlau
pushed a commit
to ibmruntimes/node
that referenced
this pull request
Jun 17, 2016
Notable changes:
* **http**:
- req.read(0) could cause incoming connections to stall and time out
under certain conditions. (Fedor Indutny) [nodejs#7211](nodejs/node#7211)
- When freeing the socket to be reused in keep-alive Agent wait for
both prefinish and end events. Otherwise the next request may be
written before the previous one has finished sending the body, leading
to a parser errors. (Fedor Indutny) [nodejs#7149](nodejs/node#7149)
* **npm**: upgrade npm to 3.9.5 (Kat Marchán) [nodejs#7139](nodejs/node#7139)
nodejs/node#7323
gibfahn
pushed a commit
to ibmruntimes/node
that referenced
this pull request
Jun 20, 2016
Notable changes:
* **http**:
- req.read(0) could cause incoming connections to stall and time out
under certain conditions. (Fedor Indutny) [nodejs#7211](nodejs/node#7211)
- When freeing the socket to be reused in keep-alive Agent wait for
both prefinish and end events. Otherwise the next request may be
written before the previous one has finished sending the body, leading
to a parser errors. (Fedor Indutny) [nodejs#7149](nodejs/node#7149)
* **npm**: upgrade npm to 3.9.5 (Kat Marchán) [nodejs#7139](nodejs/node#7139)
PR-URL: nodejs/node#7323
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making the test tolerant to rounding errors.